[BUGFIX] Properly decode cross domain links #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9665076017Details
💛 - Coveralls |
|
@twoldanski, thanks for fixing this. I can confirm this is working 💪 |
lukaszuznanski
approved these changes
Jul 2, 2024
kitzberger
reviewed
Aug 2, 2024
Comment on lines
+112
to
+116
| if (($linkDetails['pageuid'] ?? '') === 'current') { | ||
| return $event->getContentObjectRenderer()->getRequest()->getAttribute('site'); | ||
| } | ||
|
|
||
| return $this->siteFinder->getSiteByPageId((int)$linkDetails['pageuid']); |
There was a problem hiding this comment.
@twoldanski, @lukaszuznanski, for custom typolinks pageuid isn't set and triggers a PHP Warning: Undefined array key "pageuid".
Maybe use ($linkDetails['pageuid'] ?? 'current') === 'current') in line 112 to prevent that?
There was a problem hiding this comment.
See separate issue: #762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #741